[lkml]   [2008]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC][PATCH] x86: don't destroy %rbp on kernel-mode faults
Vegard Nossum wrote:
> Hi,
> The RFC part of this patch is: Does anybody see why touching %rcx would
> be bad? It certainly looks like %ecx is free. This fixes the stacktrace
> problem I was seeing, and Pekka tested a bootup to userspace. (Pekka also
> did half of the debugging. When will git allow multiple authors for a
> patch? :-))

The patch is ok, but I'm sure there's lots of other assembler code that
destroys %rbp when it was saved elsewhere.

When I wrote all the assembler the assumption was always that a real
unwinder would be used for backtraces, not frame pointer.


 \ /
  Last update: 2008-05-19 23:19    [W:0.056 / U:3.856 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site