Messages in this thread | | | Date | Mon, 19 May 2008 21:02:56 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH] decodecode: use cross-compiler/toolchain if defined |
| |
On Mon, May 12, 2008 at 03:52:42PM +0200, Vegard Nossum wrote: > Hi Sam, > > Not sure if this is really in the kbuild domain, but I see you've taken > patches to this script before, so I'll make an attempt too :-)
Fine - and thanks for the reminder (in private mail).
> > Vegard > > > From 75166add6121dbda4fad2e197d4fe6525dee580c Mon Sep 17 00:00:00 2001 > From: Vegard Nossum <vegard.nossum@gmail.com> > Date: Mon, 12 May 2008 15:36:38 +0200 > Subject: [PATCH] decodecode: use cross-compiler/toolchain if defined > > From the Makefile: "CROSS_COMPILE specify [sic] the prefix used for all > executables used". > > This is also very useful for decoding oopses on other archs than the > native one, so it seems natural to have it in the decodecode script as > well.
I agree with the intent of this patch. But as it is my experience that most people use CROSS_COMPILE on the commandline and not as an environmnet variable most will not benefit from this patch.
We should as a minimum document this use of decodecode where we document its usage today (oops-tracing.txt).
We could also make it a Makefile target thus it is a bit more natural to supply the typical Makefile parameters?
Please rework one way or the other.
Sam
| |