lkml.org 
[lkml]   [2008]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/20] tty: Introduce a tty_port common structure
    Hi Alan.

    On Mon, May 19, 2008 at 03:50:13PM +0100, Alan Cox wrote:
    > From: Alan Cox <alan@redhat.com>
    >
    > Every tty driver has its own concept of a port structure and because they all
    > differ we cannot extract commonality. Begin fixing this by creating a structure
    > drivers can elect to use so that over time we can push fields into this and
    > create commonality and then introduce common methods.
    > ---
    >
    > drivers/char/tty_io.c | 37 +++++++++++++++++++++++++++++++++++++
    > include/linux/tty.h | 29 +++++++++++++++++++++++++++++
    > 2 files changed, 66 insertions(+), 0 deletions(-)
    >
    >
    > diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
    > index 49c1a22..fb17b18 100644
    > --- a/drivers/char/tty_io.c
    > +++ b/drivers/char/tty_io.c
    > @@ -2004,6 +2004,43 @@ ssize_t redirected_tty_write(struct file *file, const char __user *buf,
    > return tty_write(file, buf, count, ppos);
    > }
    >
    > +void tty_port_init(struct tty_port *port)
    > +{
    > + memset(port, 0, sizeof(*port));
    > + init_waitqueue_head(&port->open_wait);
    > + init_waitqueue_head(&port->close_wait);
    > + mutex_init(&port->mutex);
    > +}
    > +
    > +EXPORT_SYMBOL(tty_port_init);
    A small nitpick...
    The typical style is to let the EXPORT_SYMBOL follow the closing
    brace with no extra empty line.

    Sam


    \
     
     \ /
      Last update: 2008-05-19 19:49    [W:0.022 / U:123.588 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site