lkml.org 
[lkml]   [2008]   [May]   [19]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
FromJiri Slaby <>
Subjectext4-mm-delalloc-ext4-lock-reverse-fix
DateMon, 19 May 2008 17:24:47 +0200
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Mon, 19 May 2008 15:15:09 +0800 "Dave Young" <hidave.darkstar@gmail.com> wrote:
> 
> > Hi,
> > 
> > With 2.6.26-rc2-mm1 I need to sync frequently. It's not normal as my
> > understanding.
> > 
> > 1. scp a big file from a lan server. Firstly the speed is about 8M/s,
> > but the speed will slow down to 100K/s at last. After I exec "sync",
> > the speed will restore.
> > 
> > Is this a known issue?
> > 
> 
> Yes, probably related to the "mkfs takes forever" problem.  I haven't
> looked into it yet.  Nor has anyone else afaik.

Absolutely not sure what this breaks in ext4, but fixes the problem for me:
---
 mm/page-writeback.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 040bc7c..789b6ad 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -881,7 +881,7 @@ int write_cache_pages(struct address_space *mapping,
 	pagevec_init(&pvec, 0);
 	if (wbc->range_cyclic) {
 		index = mapping->writeback_index; /* Start from prev offset */
-		end = wbc->range_end >> PAGE_CACHE_SHIFT;
+		end = -1;
 	} else {
 		index = wbc->range_start >> PAGE_CACHE_SHIFT;
 		end = wbc->range_end >> PAGE_CACHE_SHIFT;
-- 
1.5.4.5


\
 
 \ /
  Last update: 2008-05-19 17:29    [from the cache]
©2003-2008