Messages in this thread | | | Subject | Re: [PATCH] selinux: reorder inode_security_struct to increase objs/slab on 64bit | From | Stephen Smalley <> | Date | Mon, 19 May 2008 07:39:45 -0400 |
| |
On Sun, 2008-05-18 at 12:32 +0100, Richard Kennedy wrote: > reorder inode_security_struct to remove padding on 64 bit builds > > size reduced from 72 to 64 bytes increasing objects per slab to 64. > > Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk> > > --- > This patch is against 2.6.26-r2 & boots successfully on my AMD64 > desktop. > > > Richard > > > > diff --git a/security/selinux/include/objsec.h b/security/selinux/include/objsec.h > index 032c235..5f0be19 100644 > --- a/security/selinux/include/objsec.h > +++ b/security/selinux/include/objsec.h > @@ -43,8 +43,8 @@ struct inode_security_struct { > u32 sid; /* SID of this object */ > u16 sclass; /* security class of this object */ > unsigned char initialized; /* initialization flag */ > - struct mutex lock; > unsigned char inherit; /* inherit SID from parent entry */
Let's just drop inherit altogether - dead field.
> + struct mutex lock; > }; > > struct file_security_struct { > -- Stephen Smalley National Security Agency
| |