Messages in this thread Patch in this message | | | Date | Sun, 18 May 2008 00:09:29 -0500 | From | James Cammarata <> | Subject | Re: [PATCH updated] net: add ability to clear per-interface network statistics via procfs |
| |
> You need to stop your mail client word-wrapping patches. It looks like > something has converted tabs to spaces, too.
Hmm, I don't know what might be causing that. I'm using Thunderbird and disabled wrapping, and things look ok on lkml when I view the archives there. The tab/spaces issue was a result of me copying it out of a terminal window, and the patch now clears checkpatch.pl.
As for the rest, I've done as you suggested, my only comment about it is that like I said, my code is based heavily on that found in drivers/scsi/scsi_proc.c, so it may be worth it to do the same changes there.
---
--- linux-2.6.25.4/net/core/dev.c 2008-05-15 10:00:12.000000000 -0500 +++ linux-2.6.25.4-jcammara/net/core/dev.c 2008-05-17 20:53:13.000000000 -0500 @@ -2453,6 +2453,75 @@ static struct netif_rx_stats *softnet_ge return rc; } +/** + * proc_net_dev_write - handle writes to /proc/net/dev + * @file: not used + * @buf: buffer to write + * @length: length of buf, at most PAGE_SIZE + * @ppos: not used + * + * Description: this provides a mechanism to clear statistics on a + * per-interface basis + * "echo 'net clear-stats ifdev' >/proc/net/dev" + * with "ifdev" replaced by the device name you wish to clear. + * + */ +static ssize_t proc_net_dev_write(struct file *file, const char __user *buf, + size_t length, loff_t *ppos) +{ + char *buffer, *p; + char devname[IFNAMSIZ]; + static const char command[] = "net clear-stats "; + struct net *net; + struct net_device *dev; + int err; + + if (!buf || length > PAGE_SIZE) + return -EINVAL; + + buffer = (char *)__get_free_page(GFP_KERNEL); + if (!buffer) + return -ENOMEM; + + err = -EFAULT; + if (copy_from_user(buffer, buf, length)) + goto out; + + err = -EINVAL; + if (length < PAGE_SIZE) + buffer[length] = '\0'; + else if (buffer[PAGE_SIZE-1]) + goto out; + + err = -ENXIO; + net = get_proc_net(file->f_dentry->d_inode); + if (!net) + goto out; + + if (!strncmp(command, buffer, sizeof(command) - 1)) { + p = buffer + strlen(command); + if (sscanf(p, "%16s", devname) > 0) { + dev = dev_get_by_name(net, devname); + if (dev) { + if (dev->get_stats) { + struct net_device_stats *stats = + dev->get_stats(dev); + memset(stats, 0, + sizeof(struct net_device_stats)); + } + dev_put(dev); + err = length; + } + } + } + + put_net(net); + + out: + free_page((unsigned long)buffer); + return err; +} + static void *softnet_seq_start(struct seq_file *seq, loff_t *pos) { return softnet_get_online(pos); @@ -2496,6 +2565,7 @@ static const struct file_operations dev_ .owner = THIS_MODULE, .open = dev_seq_open, .read = seq_read, + .write = proc_net_dev_write, .llseek = seq_lseek, .release = seq_release_net, };
| |