lkml.org 
[lkml]   [2008]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH, RFC] char dev BKL pushdown
    From
    Date
    Arnd Bergmann <arnd@arndb.de> wrote:

    > Note that the majority of drivers use (grep suggests up to 165
    > of them) uses misc_register instead of register_chrdev/cdev_add.
    > Your patches are still correct, because you pushed the BKL into the
    > misc_open function, but there is an obvious next step in pushing
    > it further into the misc drivers.

    There's a few intermediate dispatcher levels like this, actually.
    Lots of video drivers get called behind video_open(), usb drivers from
    usb_open(), etc. Not much to be done but to push things down one level
    at a time.

    > In your current git tree, this change is no longer the final one, so
    > bisecting the series may cause other bugs. You should probably reorder
    > the patches at some point to avoid this.

    Bisection is going to be problem regardless - if a problem turns up,
    it's going to be the chrdev_open() change which gets fingered. I bet,
    though, that it will be a rare BKL-related problem which is reproducible
    enough to be easily bisectable.

    But, yes, I do need to reorganize the patch series once I'm done adding
    on changes.

    jon


    \
     
     \ /
      Last update: 2008-05-18 22:29    [W:4.492 / U:0.492 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site