Messages in this thread | | | Date | Sun, 18 May 2008 09:33:14 +0100 | From | Jeremy Fitzhardinge <> | Subject | Re: [RFC] x86: merge nmi_32-64 to nmi.c |
| |
Cyrill Gorcunov wrote: > I think I would prefer Maciej's advice then but with capital > letters (to easy distinguish them and point an attention) like > > #ifdef CONFG_X86_64 > #define CPU_64 1 > #else > #define CPU_64 0 > #endif
The other problem in this case is that cpu_pda() doesn't exit for 32-bit, so it probably won't compile anyway. But in general, I fully support using if (constant) over #ifdef (?: not so much).
J
| |