lkml.org 
[lkml]   [2008]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] x86: merge nmi_32-64 to nmi.c
    [Jeremy Fitzhardinge - Sun, May 18, 2008 at 08:25:38AM +0100]
    > Thomas Gleixner wrote:
    >> Definitely, but we should do it at the Kconfig level which allows us
    >> to have integer defines as well, so we end up with something like:
    >>
    >> static inline unsigned int get_nmi_count(int cpu)
    >> {
    >> return CONFIG_X86_64 ? cpu_pda(cpu)->__nmi_count : nmi_count(cpu);
    >> }
    >>
    >
    > Unfortunately that doesn't work because when CONFIG_X86_64 isn't defined it
    > doesn't expand to 0. It would be nice if CONFIG_* expanded to 0/1, but
    > we'd need to change all the #ifdef CONFIG_* to #if CONFIG_*...
    >
    > J
    >

    I think I would prefer Maciej's advice then but with capital
    letters (to easy distinguish them and point an attention) like

    #ifdef CONFG_X86_64
    #define CPU_64 1
    #else
    #define CPU_64 0
    #endif

    - Cyrill -


    \
     
     \ /
      Last update: 2008-05-18 09:43    [W:0.069 / U:210.888 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site