Messages in this thread | | | Subject | Re: [PATCH] remove double indirection on tlb parameter to free_pgd_range()& Co | From | Benjamin Herrenschmidt <> | Date | Sat, 17 May 2008 10:27:43 -0500 |
| |
On Fri, 2008-05-16 at 16:30 +0100, Jan Beulich wrote: > >>> Hugh Dickins <hugh@veritas.com> 16.05.08 16:39 >>> > > Pass mmu_gather** in the > > public interfaces, since we might want to add latency lockdrops later; > > but no attempt to do so yet, going by vma should itself reduce latency. > >... > >But, returning to the start, please let's hold yours back after all. > > If you want to keep and actively use the double indirection, would you > guarantee current semantics like ->mm and ->fullmm to always be what > was specified at the start of the operation? Verifying this was what > made me go through that call tree in the first place, and obviously this > is harder to verify when there is potential for the whole structure > pointed to to be replaced by another one.
In my patches, I did drop the double indirection and just updated the fields inside of the batch. Worked fine.
Ben.
| |