Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [patch 07/22] fat: dont call notify_change | Date | Sat, 17 May 2008 08:25:15 +0900 |
| |
Miklos Szeredi <miklos@szeredi.hu> writes:
> From: Miklos Szeredi <mszeredi@suse.cz> > > The FAT_IOCTL_SET_ATTRIBUTES ioctl() calls notify_change() to change > the file mode before changing the inode attributes. Replace with > explicit calls to security_inode_setattr(), fat_setattr() and > fsnotify_change(). > > This is equivalent to the original. The reason it is needed, is that > later in the series we move the immutable check into notify_change(). > That would break the FAT_IOCTL_SET_ATTRIBUTES ioctl, as it needs to > perform the mode change regardless of the immutability of the file. > > Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> > CC: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Don't we need to add EXPORT_SYMBOL(security_inode_setattr)? Otherwise, looks good to me.
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Thanks. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |