Messages in this thread |  | | | Date | Fri, 16 May 2008 09:13:41 -0400 | | From | Dmitry Torokhov <> | | Subject | Re: [PATCH] Input: add appleir USB driver |
| |
On Thu, May 15, 2008 at 10:59:50PM +0200, Tino Keitel wrote: > On Thu, May 15, 2008 at 14:35:54 -0400, Dmitry Torokhov wrote: > > On Thu, May 15, 2008 at 07:49:39PM +0200, Tino Keitel wrote: > > > > > From the user's point of view: There are no official kernel release > > > notes about what devices are added/removed to/from the various > > > ignore lists and blacklists. The kernel doesn't produce any output > > > about devices that are ignored or blacklisted in may cases (and > > > also this one). The user has no indication why his LIRC setup stops > > > working with the new kernel. > > > > > > > Not sure what we can do here... The only thing I guess is better > > commit message mentioning LIRC setup concerns. > > Who reads commit messages? I think it should be easy to add some > printk()s saying something like "skipping device foo, because it is on > the ignore list".
Then every user of Wacom tablet will be alarmed and ask "why my tablet is ignored". The only thing that I can think of is making that quirk compiled in depending on whether CONFIG_APPLEIR is selected.
> > > > Even if all LIRC users switch to the appleir driver, what about > > > people who use a learning remote to have more than 6 keys that the > > > Apple remote has? Does this work at all? After a quick look at the > > > key handling it seems to me that the codes of the 6 keys are > > > hardcoded in the driver. So a learning remote with more keys > > > wouldn't work anymore. > > > > > > > We'll have to adjust the driver to allow changing keymap on a > > per-device base from userspace. That's pretty easy actually. > > I'm not talking about the keymap that is visible in userspace, but > about the keys on the remote that are detected by the kernel. The Apple > remote has only 6 keys, and they are mapped in a static array: > > #define MAX_KEYS 8 > static int keymap[MAX_KEYS] = ... > > With the LIRC driver, I can use a learning remote with much more keys, > and then just use irrecord to create a LIRC config file. >
Does the learning remote have the same VID/PID as AppleIr? If not I am not sure why you are btringing it here.
-- Dmitry
|  |