lkml.org 
[lkml]   [2008]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [rtc-linux] [PATCH] add support for ST M41T94 SPI RTC (patch rev. 2)
On Thu, 15 May 2008 12:53:05 +0300
"Kim B. Heino" <Kim.Heino@bluegiga.com> wrote:

>
> +struct m41t94 {
> + struct rtc_device *rtc;
> +};

[...]


> +
> +static int __devinit m41t94_probe(struct spi_device *spi)
> +{
> + struct rtc_device *rtc;
> + struct m41t94 *m41t94;
> + int res;
> +
> + m41t94 = kzalloc(sizeof(struct m41t94), GFP_KERNEL);
> + if (!m41t94)
> + return -ENOMEM;
> + dev_set_drvdata(&spi->dev, m41t94);

[..]

> + rtc = rtc_device_register(m41t94_driver.driver.name,
> + &spi->dev, &m41t94_rtc_ops, THIS_MODULE);
> + if (IS_ERR(rtc)) {
> + kfree(m41t94);
> + return PTR_ERR(rtc);
> + }
> +
> + m41t94->rtc = rtc;
> +
> + return 0;
> +}
>

thanks for having implemented the sugestions.

one more thing. now that the struct m41t94 is
almost empty it makes no sense to keep it.

--

Best regards,

Alessandro Zummo,
Tower Technologies - Torino, Italy

http://www.towertech.it



\
 
 \ /
  Last update: 2008-05-15 12:15    [W:0.021 / U:1.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site