Messages in this thread | | | Date | Thu, 15 May 2008 17:15:24 +0800 | From | Jie Zhang <> | Subject | Re: [PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers to fix more potential unaligned issues. |
| |
Oliver Neukum wrote: > Am Donnerstag 15 Mai 2008 10:03:35 schrieb Jie Zhang: >> Oliver Neukum wrote: >>> Am Donnerstag 15 Mai 2008 08:19:24 schrieb Bryan Wu: >>>> --- a/drivers/usb/host/uhci-hub.c >>>> +++ b/drivers/usb/host/uhci-hub.c >>>> @@ -253,7 +253,7 @@ static int uhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, >>>> switch (typeReq) { >>>> >>>> case GetHubStatus: >>>> - *(__le32 *)buf = cpu_to_le32(0); >>>> + put_unaligned_le32(0, buf); >>> What is supposed to make all these changes a good idea? >>> >> Since buf might not be 4-byte aligned. > > It is. Please analyze the code before you use these access methods. > You are right. buf has been 4-byte aligned since 2.6.19. My patch was written two years ago. Sorry for the noise I caused.
Jie
| |