Messages in this thread |  | | | Date | Wed, 14 May 2008 17:32:09 +0900 | | From | KAMEZAWA Hiroyuki <> | | Subject | Re: [RFC/PATCH 4/6] memcg: shmem reclaim helper | |
On Wed, 14 May 2008 16:23:09 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:
> KAMEZAWA Hiroyuki wrote:
> > On Wed, 14 May 2008 16:15:49 +0800
> > Li Zefan <lizf@cn.fujitsu.com> wrote:
> >
> >>> + while(!progress && --retry) {
> >>> + progress = try_to_free_mem_cgroup_pages(mem, gfp_mask);
> >>> + }
> >> This is wrong. How about:
> >> do {
> >> ...
> >> } while (!progress && --retry);
> >>
> > Ouch, or retry--....
> >
>
> retry-- is still wrong, because then after while, retry will be -1, and then:
>
> + if (!retry)
> + return -ENOMEM;
>
ok, i'm now rewriting.
Thanks,
-Kame
|  |