lkml.org 
[lkml]   [2008]   [May]   [14]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateWed, 14 May 2008 17:25:31 +0900
FromKAMEZAWA Hiroyuki <>
SubjectRe: [RFC/PATCH 4/6] memcg: shmem reclaim helper
On Wed, 14 May 2008 16:15:49 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:

> > +	while(!progress && --retry) {
> > +		progress = try_to_free_mem_cgroup_pages(mem, gfp_mask);
> > +	}
> 
> This is wrong. How about:
> 	do {
> 		...
> 	} while (!progress && --retry);
> 
Ouch, or retry--....

Thank you for catching.

Thanks
-Kame



\
 
 \ /
  Last update: 2008-05-14 10:23    [from the cache]
©2003-2008