Messages in this thread |  | | | Date | Thu, 15 May 2008 01:09:46 +0530 | | From | Balbir Singh <> | | Subject | Re: [-mm][PATCH 4/4] Add memrlimit controller accounting and control (v4) | |
* Pavel Emelyanov <xemul@openvz.org> [2008-05-14 17:32:42]:
>
> AFAIS you didn't cover all the cases when VM expands. At least all
> the arch/ia64/ia32/binfmt_elf32.c is missed.
>
> I'd insert this charge into insert_vm_struct. This would a) cover
> all of the missed cases and b) reduce the amount of places to patch.
>
I thought I have those covered. insert_vm_struct() is called from
places that we have covered in this patch. As far as
arch/ia64/ia32/binfmt_elf32.c is concerned, it inserts a GDT, LDT
and does not change total_vm. Having said that, I am not against
putting the hooks in insert_vm_struct().
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
|  |