lkml.org 
[lkml]   [2008]   [May]   [14]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateWed, 14 May 2008 20:53:08 +0200
FromAlessandro Zummo <>
SubjectRe: [rtc-linux] Re: [PATCH] add support for ST M41T94 SPI RTC
On Wed, 14 May 2008 17:23:35 +0300
"Kim B. Heino" <Kim.Heino@bluegiga.com> wrote:

>
> 
> >> +struct m41t94 {
> >> +	struct rtc_device *rtc;
> >> +	u8 buf[8]; /* Burst read cmd + 7 registers */
> >> +};
> >  why are you keeping the buffer here?
> 
> rtc-max6902.c did that too... Fixed.

 d'oh! I missed it. :)

> >  the choice is up to you, but I'd use the century bit if there
> >  is one.
> 
> Ok, I'll add support for century bit. Again there are some other 
> rtc-drivers (like rtc-m41t80.c and rtc-ds1307.c) not using it.

 it's not mandatory, just a suggestion.

> 
> I'll wait for more comments and post a new patch tomorrow.

 ok, thanks.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it



\
 
 \ /
  Last update: 2008-05-14 20:55    [from the cache]
©2003-2008