Messages in this thread |  | | | Date | Wed, 14 May 2008 15:22:00 +0300 | | From | "Pekka Enberg" <> | | Subject | Re: [PATCH] kallsyms: fix potential overflow in binary search | |
On Wed, May 14, 2008 at 2:44 PM, Paulo Marques <pmarques@grupopie.com> wrote:
> > This will probably never trigger... but it won't hurt to be careful.
>
> Not "probably", this will never trigger _period_. If you ever have more
> than 2^31 symbols in the kernel's kallsyms table you'll have worse problems
> to worry about than the binary search overflowing.
>
> So, I don't think it is worth this des-optimization at all...
Yes it is. It serves as correct reference code and the
"deoptimization" is not measurable.
|  |