lkml.org 
[lkml]   [2008]   [May]   [13]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    DateTue, 13 May 2008 13:12:51 -0700
    FromGreg KH <>
    Subject[patch 35/37] SCSI: aha152x: fix init suspiciously returned 1, it should follow 0/-E convention
    2.6.25-stable review patch.  If anyone has any objections, please let us
    know.
    
    ------------------
    From: James Bottomley <James.Bottomley@HansenPartnership.com>
    commit ad2fa42d044b98469449880474a9662fb689f7f9 upstream
    
    Reported-by: Frank de Jong <frapex@xs4all.nl>
    > [1.] One line summary of the problem:> linux-2.6.25.3, aha152x'->init suspiciously returned 1, it should
    > follow 0/-E convention. The module / driver works okay. Unloading the
    > module is impossible.
    
    The driver is apparently returning 0 on failure and 1 on success.
    That's a bit unfortunate.  Fix it by altering to -ENODEV and 0.
    
    Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    
    ---
     drivers/scsi/aha152x.c |    4 ++--
     1 file changed, 2 insertions(+), 2 deletions(-)
    --- a/drivers/scsi/aha152x.c
    +++ b/drivers/scsi/aha152x.c
    @@ -3835,7 +3835,7 @@ static int __init aha152x_init(void)
     			iounmap(p);
     		}
     		if (!ok && setup_count == 0)
    -			return 0;
    +			return -ENODEV;
     
     		printk(KERN_INFO "aha152x: BIOS test: passed, ");
     #else
    @@ -3914,7 +3914,7 @@ static int __init aha152x_init(void)
     #endif
     	}
     
    -	return 1;
    +	return 0;
     }
     
     static void __exit aha152x_exit(void)
    -- 
    
    
    
    \
     
     \ /
      Last update: 2008-05-13 22:29    [from the cache]
    ©2003-2008