Messages in this thread | | | Date | Tue, 13 May 2008 20:18:34 +0200 | From | Johannes Stezenbach <> | Subject | Re: [patch, 2.6.26-rc2] dvb: drivers/media/dvb/ttpci/fdump firmware build error fix |
| |
On Tue, May 13, 2008 at 06:42:38PM +0200, Ingo Molnar wrote: > > * Johannes Stezenbach <js@linuxtv.org> wrote: > > > On Tue, May 13, 2008 at 04:33:54PM +0200, Oliver Endriss wrote: > > > Johannes Stezenbach wrote: > > > > You can put PREVENT_FIRMWARE_BUILD=y in your allrandom.config. > > > > > > Sure. And without the patch you can simply add > > > - STANDALONE=y or > > > - DVB_AV7110_FIRMWARE=n > > > to your allrandom.config. ;-) > > > > It is desirable to have one generic "don't break the build because of > > missing firmware binaries" option, isn't it? > > it's a bit confusing. PREVENT_FIRMWARE_BUILD=y is the 'weaker' option - > a driver might still be operational (with its default firmware), even if > no firmware is built. STANDALONE=y is the stronger option - if a driver > depends on that it means that the driver cannot be built (and used) at > all without a firmware file. To be on the safe side users who have no > firmware needs should set both options. (and that's the default as well)
Seems like I'm confused now...
CONFIG_STANDALONE Prompt: Select only drivers that don't need compile-time external firmware
PREVENT_FIRMWARE_BUILD Prompt: Prevent firmware from being built
I guess selecting either one should prevent the build issue you got, so your patch is right. But I also was wrong on the meaning of STANDALONE... Now I wonder why PREVENT_FIRMWARE_BUILD exists at all.
Johannes
| |