lkml.org 
[lkml]   [2008]   [May]   [13]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 13 May 2008 14:07:37 +0800
From"Bryan Wu" <>
SubjectRe: [PATCH 1/1] [net/irda]: Fix a misalign access issue.
On Tue, May 13, 2008 at 12:14 PM, David Miller <davem@davemloft.net> wrote:
> From: "Yang, Graf" <Graf.Yang@analog.com>
>  Date: Tue, 13 May 2008 12:07:35 +0800
>
>
>  > I have tried
>  > struct irda_device_info {
>  >         __u32       saddr;    /* Address of local interface */
>  >         __u32       daddr;    /* Address of remote device */
>  >         char        info[22]; /* Description */
>  >         __u8        charset;  /* Charset used for description */
>  >         __u8        reserve;  /* For align data */
>  >         __u8        hints[2]; /* Hint bits */
>  > };
>  >
>  > It works with my irda driver. Can I modify it like this?
>
>  This header file and the irda_device_info datastructure are exported
>  to, and used by, userspace.
>
>  Therefore you cannot change this structure's layout without breaking
>  every single existing IRDA binary out there.
>

Exactly, so we plan to add put/get_unaligned method to fix this issue.
After Graf fix it, I will send out the patch

Thanks
-Bryan


\
 
 \ /
  Last update: 2008-05-13 08:11    [from the cache]
©2003-2008