lkml.org 
[lkml]   [2008]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/2] x86: head_64.S cleanup - use straight move to CR4 register
[H. Peter Anvin - Tue, May 13, 2008 at 10:03:42AM -0700]
> Cyrill Gorcunov wrote:
>> There is no need for testing the values because we already know
>> what they should be. Just set them in straight way.
>
> He isn't testing them, he's setting individual bits.

not exactly - bts: bit test and set

>
> Either of these is pretty silly; the right way to do this is:
>
> movl $(X86_CR4_PAE|X86_CR4_PGE), %eax
> movq %rax, %cr4
>
> A movl in 64-bit mode zero extends.
>
> -hpa
>
ok, thanks Peter, i'll update in minute ;)

- Cyrill -


\
 
 \ /
  Last update: 2008-05-13 19:11    [W:0.041 / U:2.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site