lkml.org 
[lkml]   [2008]   [May]   [13]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 13 May 2008 10:03:42 -0700
From"H. Peter Anvin" <>
SubjectRe: [patch 1/2] x86: head_64.S cleanup - use straight move to CR4 register
Cyrill Gorcunov wrote:
> There is no need for testing the values because we already know
> what they should be. Just set them in straight way.

He isn't testing them, he's setting individual bits.

Either of these is pretty silly; the right way to do this is:

	movl	$(X86_CR4_PAE|X86_CR4_PGE), %eax
	movq	%rax, %cr4
A movl in 64-bit mode zero extends.

	-hpa


\
 
 \ /
  Last update: 2008-05-13 19:07    [from the cache]
©2003-2008