Messages in this thread | | | Date | Tue, 13 May 2008 17:51:32 +0100 (BST) | From | "Maciej W. Rozycki" <> | Subject | Re: [PATCH 3/6] RTC: SWARM I2C board initialization (#2) |
| |
Hi Jean,
> > 1. swarm-i2c.c -- SWARM I2C board setup, currently for the M41T80 chip on > > the bus #1 only (there is a MAX6654 temperature sensor on the bus #0 > > which may be added in the future if we have a driver for that chip). > > We don't have a driver yet, however the datasheet for that chip is > publicly available and writing a driver would be easy. Or maybe just > reuse an existing driver - from a quick look at the datasheet I suspect > that this device is essentially compatible with the LM90 and ADM1032 > chips supported by the lm90 driver.
True, but someone has to do that. I feel no incentive at the moment. ;-)
> > 2. The i2c-sibyte.c BCM1250A SMBus controller driver now registers its > > buses as numbered so that board setup is correctly applied. > > > > Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org> > > --- > > I have renamed i2c-swarm.c to swarm-i2c.c for consistency with names > > of other files under arch/mips/. > > But you forgot to update the log message accordingly...
I did not, unless I am missing something.
> > Please note this patch trivially depends on > > patch-2.6.26-rc1-20080505-swarm-core-16 -- 2/6 of this set. > > OK, so I should just wait for patch 2/6 to get upstream before I add > this one to my i2c tree?
Either this or you can apply both and remove the local copy of the former when it comes back from upstream. Whatever you prefer -- it is your choice.
Maciej
| |