lkml.org 
[lkml]   [2008]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] asm-generic/bitops/fls64.h
    Andrew Morton пишет:
    > On Sun, 04 May 2008 22:58:50 +0400
    > ____________________ ______________ ____________________ <nickolay@protei.ru> wrote:
    >
    >> bugfix in fls64 on a big endian systems(against 2.6.25).
    >>
    >> Signed-off-by: Nickolay Vinogradov <nickolay@protei.ru>
    >>
    >> --
    >>
    >> diff --git a/include/asm-generic/bitops/fls64.h
    >> b/include/asm-generic/bitops/fls64.h
    >> index 1b6b17c..2eedb6f 100644
    >> --- a/include/asm-generic/bitops/fls64.h
    >> +++ b/include/asm-generic/bitops/fls64.h
    >> @@ -8,7 +8,7 @@ static inline int fls64(__u64 x)
    >> __u32 h = x >> 32;
    >> if (h)
    >> return fls(h) + 32;
    >> - return fls(x);
    >> + return fls((__u32)x);
    >> }
    >>
    >> #endif /* _ASM_GENERIC_BITOPS_FLS64_H_ */
    >
    > Please describe the bug which you are fixing?
    >
    > Perhaps a more robust fix to <whatever the bug is> would be to
    > repair fls() so that it works correctly when passed a u64. Perhaps.

    Repair fls64() so that it works correctly when passed a u64.

    --
    Nickolay Vinogradov
    Protei Research and Development Center
    St.Petersburg, 194044, Russia
    Tel.: +7 812 449 47 27
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-05-13 12:47    [W:3.682 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site