lkml.org 
[lkml]   [2008]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] [8250 Serial Driver]: Added support for 8250-class UARTs in HV Sistemas H8606 board
    > 
    > +#ifdef SERIAL_EXTRA_IRQ_FLAGS
    > + irq_flags |= SERIAL_EXTRA_IRQ_FLAGS;
    > +#endif
    > +


    We try and keep ifdefs out of code. It is also not clear what you would
    do if you had a box where the extra flags depended on the port.

    So two suggestions

    Either

    Add just the line

    + irq_flags |= SERIAL_EXTRA_IRQ_FLAGS;

    and at the end of 8250.h do

    #ifndef SERIAL_EXTRA_IRQ_FLAGS
    #define SERIAL_EXTRA_IRQ_FLAGS 0
    #endif

    or the same but with an argument (unused for now)

    SERIAL_EXTRA_IRQ_FLAGS(up)

    Alan


    \
     
     \ /
      Last update: 2008-05-12 12:07    [W:0.022 / U:0.892 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site