lkml.org 
[lkml]   [2008]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 18/18] flag parameters: check magic constants
From
From: Andrew Morton <akpm@linux-foundation.org>
Date: Mon, 12 May 2008 20:13:41 -0700

> On Tue, 6 May 2008 17:18:07 -0400 Ulrich Drepper <drepper@redhat.com> wrote:
>
> > --- a/net/socket.c
> > +++ b/net/socket.c
> > @@ -1219,6 +1219,13 @@ asmlinkage long sys_socket(int family, int type, int protocol)
> > struct socket *sock;
> > int flags;
> >
> > + /* Check the SOCK_* constants for consistency. */
> > + BUILD_BUG_ON(SOCK_CLOEXEC != O_CLOEXEC);
> > + BUILD_BUG_ON(SOCK_NONBLOCK != O_NONBLOCK);
> > + BUILD_BUG_ON((SOCK_MAX | SOCK_TYPE_MASK) != SOCK_TYPE_MASK);
> > + BUILD_BUG_ON(SOCK_CLOEXEC & SOCK_TYPE_MASK);
> > + BUILD_BUG_ON(SOCK_NONBLOCK & SOCK_TYPE_MASK);
>
> The fifth assertion triggers with alpha allmodconfig.

Unfortunately, MIPS and PARISC look like they will as well :-/


\
 
 \ /
  Last update: 2008-05-13 05:49    [W:0.199 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site