Messages in this thread | | | Date | Mon, 12 May 2008 08:52:33 +0200 | From | Pavel Machek <> | Subject | Re: 2.6.26-rc1 on x86: ld: warning: dot moved backwards before `.text' |
| |
On Sun 2008-05-11 23:22:52, Rafael J. Wysocki wrote: > On Sunday, 11 of May 2008, Cyrill Gorcunov wrote: > > [H. Peter Anvin - Sun, May 11, 2008 at 11:25:54AM -0700] > > > Cyrill Gorcunov wrote: > > >> Hi Peter, > > >> actually I only doubt about exactly position of this headers - I mean > > >> meguess it better should be _before_ "_end" not after. Since the others > > >> script uses (acpi/wakeup_rm.S): > > >> wakeup_code_start: > > >> .incbin "arch/x86/kernel/acpi/realmode/wakeup.bin" > > >> wakeup_code_end: > > >> and kernel uses these wakeup_code_* marks to save/restore memory I think > > >> it should be like > > >> . = HEADER_OFFSET; > > >> .header : { > > >> ... > > >> } > > >> . = ALIGN(16); > > >> _end = .; > > >> /DISCARD/ ... > > > > > > Yes, I believe that's correct. > > > > > > -hpa > > > > > > > Thanks for review, Peter, I'll cook a patch and wait for > > Pavel's opinion ;-) > > I've tested the appended one. If that's what you mean, we'll ask Ingo to take > it.
ACK... and thanks! Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |