lkml.org 
[lkml]   [2008]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 18/18] flag parameters: check magic constants
On Tue, 6 May 2008 17:18:07 -0400 Ulrich Drepper <drepper@redhat.com> wrote:

> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -1219,6 +1219,13 @@ asmlinkage long sys_socket(int family, int type, int protocol)
> struct socket *sock;
> int flags;
>
> + /* Check the SOCK_* constants for consistency. */
> + BUILD_BUG_ON(SOCK_CLOEXEC != O_CLOEXEC);
> + BUILD_BUG_ON(SOCK_NONBLOCK != O_NONBLOCK);
> + BUILD_BUG_ON((SOCK_MAX | SOCK_TYPE_MASK) != SOCK_TYPE_MASK);
> + BUILD_BUG_ON(SOCK_CLOEXEC & SOCK_TYPE_MASK);
> + BUILD_BUG_ON(SOCK_NONBLOCK & SOCK_TYPE_MASK);

The fifth assertion triggers with alpha allmodconfig.


\
 
 \ /
  Last update: 2008-05-13 05:17    [from the cache]
©2003-2011 Jasper Spaans