Messages in this thread |  | | | Date | Mon, 12 May 2008 14:45:07 -0700 | | From | Andrew Morton <> | | Subject | Re: [PATCH] asm-generic/bitops/fls64.h | |
On Sun, 04 May 2008 22:58:50 +0400
____________________ ______________ ____________________ <nickolay@protei.ru> wrote:
> bugfix in fls64 on a big endian systems(against 2.6.25).
>
> Signed-off-by: Nickolay Vinogradov <nickolay@protei.ru>
>
> --
>
> diff --git a/include/asm-generic/bitops/fls64.h
> b/include/asm-generic/bitops/fls64.h
> index 1b6b17c..2eedb6f 100644
> --- a/include/asm-generic/bitops/fls64.h
> +++ b/include/asm-generic/bitops/fls64.h
> @@ -8,7 +8,7 @@ static inline int fls64(__u64 x)
> __u32 h = x >> 32;
> if (h)
> return fls(h) + 32;
> - return fls(x);
> + return fls((__u32)x);
> }
>
> #endif /* _ASM_GENERIC_BITOPS_FLS64_H_ */
Please describe the bug which you are fixing?
Perhaps a more robust fix to <whatever the bug is> would be to
repair fls() so that it works correctly when passed a u64. Perhaps.
|  |