lkml.org 
[lkml]   [2008]   [May]   [12]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateMon, 12 May 2008 05:05:54 +0100
FromAl Viro <>
SubjectRe: [Patch 3/9] fs/compat.c: fix resource leaks and wrong goto's
On Mon, May 12, 2008 at 11:46:09AM +0800, WANG Cong wrote:
> >@@ -1320,17 +1326,15 @@ int do_execve(char * filename,
> > 	retval = search_binary_handler(bprm,regs);
> > 	if (retval >= 0) {
> > 		/* execve success */
> >-		free_arg_pages(bprm);
> > 		security_bprm_free(bprm);
> > 		acct_update_integrals(current);
> >-		kfree(bprm);
> >+		free_bprm(bprm);
> > 		if (displaced)
> > 			put_files_struct(displaced);
> > 		return retval;
> > 	}
> > 
> > out:
> >-	free_arg_pages(bprm);
> 
> 
> Why just drop this? No need to call free_bprm()?

Fixed, pushed to vfs-2.6.git...


\
 
 \ /
  Last update: 2008-05-12 06:09    [from the cache]
©2003-2008