lkml.org 
[lkml]   [2008]   [May]   [12]   [last100]   RSS Feed
Views: [more markup]   [less markup]   [headers]   [forward]  
 
Messages in this thread
/
DateMon, 12 May 2008 20:58:23 +0100
FromAlan Cox <>
SubjectRe: [PATCH] riscom8: remove redundant null pointer test
On Mon, 12 May 2008 19:27:10 +0100
Chris Malley <mail@chrismalley.co.uk> wrote:

> tty has already been dereferenced at least twice in these functions,
> so checking for null here seems a bit unnecessary.

Oh it is - and lots of the other tty checks are bogus too.

Acked-by: Alan Cox <alan@redhat.com>

Alan


\
 
 \ /
  Last update: 2008-05-12 20:15    [W:0.360 / U:0.050 seconds]
©2003-2008 Jasper Spaans