lkml.org 
[lkml]   [2008]   [May]   [12]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateMon, 12 May 2008 15:53:43 +0200
FromPavel Machek <>
SubjectRe: [PATCH] x86: wakeup.lds.S - section ordering fix
On Sun 2008-05-11 22:46:38, Cyrill Gorcunov wrote:
> To allow linker to catch sections overlapping we have to declare
> them in appropriate order.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> 
> Please test and review

Looks okay to me, but I can't easily test it right now.

But I think Rafael tested identical patch, you can add my ACK in such
case.

								Pavel

> Index: linux-2.6.git/arch/x86/kernel/acpi/realmode/wakeup.lds.S
> ===================================================================
> --- linux-2.6.git.orig/arch/x86/kernel/acpi/realmode/wakeup.lds.S	2008-05-11 20:21:58.000000000 +0400
> +++ linux-2.6.git/arch/x86/kernel/acpi/realmode/wakeup.lds.S	2008-05-11 22:34:42.000000000 +0400
> @@ -12,11 +12,6 @@ ENTRY(_start)
> 
>  SECTIONS
>  {
> -	. = HEADER_OFFSET;
> -	.header : {
> -		 *(.header)
> -	}
> -
>  	. = 0;
>  	.text : {
>  		 *(.text*)
> @@ -50,6 +45,11 @@ SECTIONS
>  		__bss_end = .;
>  	}
> 
> +	. = HEADER_OFFSET;
> +	.header : {
> +		*(.header)
> +	}
> +
>  	. = ALIGN(16);
>  	_end = .;
> 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2008-05-12 15:55    [from the cache]
©2003-2008