Messages in this thread |  | | | From | Rusty Russell <> | | Subject | Re: [PATCH 3/3] module: don't ignore vermagic string if module doesn't have modversions | | Date | Sun, 11 May 2008 10:57:34 +1000 |
On Saturday 10 May 2008 00:44:34 Linus Torvalds wrote:
> On Fri, 9 May 2008, Rusty Russell wrote:
> > We should only ignore the start of the vermagic string if the module
> > actually *has* crcs to check. Rather than (say) having an
> > entertaining hissy fit and creating a config option to work around the
> > buggy code.
>
> Btw, this makes the two vesions of "same_magic()" be basically the same
> (since without MODVERSIONS, has_crcs *should* always be zero). Maybe we
> should make it just one version, to simplify logic?
I know, but it's a little subtle.
If the module has an __versions section, yet the kernel was built without
CONFIG_MODVERSIONS, we should not ignore the first part of the version. We
could just #ifdef CONFIG_MODVERSIONS around the verindex initialization tho,
to guarantee that it's 0 for !MODVERSIONS. But that puts YA #ifdef in that
function, and I already itch to clean up the ones there...
Cheers,
Rusty.
|  |