Messages in this thread | | | Date | Thu, 1 May 2008 22:05:36 +0100 | From | Ralf Baechle <> | Subject | Re: [PATCH] clocksource: shift helper |
| |
On Thu, May 01, 2008 at 12:48:25PM -0700, Daniel Walker wrote:
> > If we expect this to have more than one callsite then it would be best to > > uninline it. > > > > Unless we always expect it to be called from __init code, in which case > > it's best to inline it ;) > > I expect it would always get called from __init flagged functions. The > clocksource can't get registed/used with out the shift and mult values. > > If we did uninline this one, we would have to do the other helpers too. > I imagine the use case is the same for all of them ..
I could imagine this being called for hotpluggable CPUs or nodes, so rather __cpuinit than __init.
Ralf
| |