lkml.org 
[lkml]   [2008]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] v4l/dvb: Add linux/version.h include as KERNEL_VERSION macro is used.
On Thu, May 01, 2008 at 08:05:41PM +0200, Andres Freund wrote:
> Whitout this build fails with unknown macro on
> e4c576b911e364737b1bf4f5bfdab1c440713f26
>
> Hopefully I did everything correct, as this is my first usage of git beside
> checking out. Also its my first patch on lk....
>
> Is an Signed-off-by already appropriate with such an trivial change?

Yes.

> Signed-off-by: Andres Freund <andres@anarazel.de>
> ---
> drivers/media/radio/radio-maxiradio.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/media/radio/radio-maxiradio.c
> b/drivers/media/radio/radio-maxiradio.c
> index 0133ecf..e170fcd 100644
> --- a/drivers/media/radio/radio-maxiradio.c
> +++ b/drivers/media/radio/radio-maxiradio.c
> @@ -34,6 +34,7 @@
>
>
> #include <linux/module.h>
> +#include <linux/version.h>
> #include <linux/init.h>
> #include <linux/ioport.h>
> #include <linux/delay.h>

The #include is already there a dozen lines below.

It seems to be missing in another file.

Can you send the error message and your .config?

Thanks
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed



\
 
 \ /
  Last update: 2008-05-01 21:35    [W:2.050 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site