[lkml]   [2008]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 1/2] Add thread_info_cache_init() to all archs
Some architecture need to maintain a kmem cache for thread info
structures. (next patch adds that to powerpc to fix an alignment

There is no good arch callback to use to initialize that cache
that I can find, so this adds a new one and adds an empty macro
for when it's not implemented.

Signed-off-by: Benjamin Herrenschmidt <>

So we have the choice here between:

- the ifdef on the func name that I did, consistent with what
I did before for iomap, which iirc Linus liked

- add some more ARCH_HAS_* or HAVE_* (yuck)

- add an empty definition to all archs .h (pain in the neck but I
can do it, though it will be an annoying patch to keep around)

- do a weak function (will slightly bloat everybody for no good reason)

So unless there is strong complaints, I'd like to stick to my
current approach.

include/linux/sched.h | 4 ++++
init/main.c | 1 +
2 files changed, 5 insertions(+)

--- linux-work.orig/init/main.c 2008-04-10 13:11:06.000000000 +1000
+++ linux-work/init/main.c 2008-04-10 13:11:19.000000000 +1000
@@ -623,6 +623,7 @@ asmlinkage void __init start_kernel(void
if (efi_enabled)
+ thread_info_cache_init();
Index: linux-work/include/linux/sched.h
--- linux-work.orig/include/linux/sched.h 2008-04-10 13:11:44.000000000 +1000
+++ linux-work/include/linux/sched.h 2008-04-10 13:12:05.000000000 +1000
@@ -1893,6 +1893,10 @@ static inline unsigned long *end_of_stac


+#ifndef thread_info_cache_init
+#define thread_info_cache_init do { } while(0)
/* set thread flags in other task's structures
* - see asm/thread_info.h for TIF_xxxx flags available

 \ /
  Last update: 2008-04-10 05:27    [W:0.062 / U:9.876 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site