lkml.org 
[lkml]   [2008]   [Apr]   [8]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 8 Apr 2008 01:23:59 -0700
FromAndrew Morton <>
SubjectRe: [PATCH 4/4] pxafb: preliminary smart panel interface support
On Tue, 8 Apr 2008 12:07:27 +0800 "eric miao" <eric.y.miao@gmail.com> wrote:

> +static int pxafb_smart_thread(void *arg)
> +{
> +	struct pxafb_info *fbi = (struct pxafb_info *) arg;

Please don't typecast when assigning a pointer to or from void*.

Reasons:

- It defeats typechecking: if someone later converts `arg' to a u8, they
  won't even get a compiler warning.

- Improved code readability.



\
 
 \ /
  Last update: 2008-04-08 10:27    [from the cache]
©2003-2008