lkml.org 
[lkml]   [2008]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/13] devres: implement managed iomap interface
Sergei Shtylyov wrote:
> A very late comment but nevertheless... :-)

Better late than never.

> Those functions are going to break on 32-bit platforms with extended
> physical address (well, that's starting with Pentiums which had 36-bit
> PAE :-) AND devices mapped beyond 4 GB (e.g. PowerPC 44x). You should
> have used resource_size_t for the 'offset' parameter. As this most
> probably means that libata is broken on such platforms, I'm going to
> submit a patch...

Yeah, right please go ahead. But I wonder whether any BIOS was actually
crazy enough to map mmio region above 4G on 32bit machine.

--
tejun


\
 
 \ /
  Last update: 2008-04-08 16:51    [W:0.061 / U:6.784 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site