lkml.org 
[lkml]   [2008]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] drivers/char/specialix.c: stop inlining largish static functions
    On Tue, Apr 08, 2008 at 12:44:53PM +0200, Denys Vlasenko wrote:
    > Hi Alan,
    >
    > drivers/char/specialix.c has unusually large number
    > of static inline functions - 22.
    >
    > I looked through them. The file is positively inline-happy.
    > Inlines with udelay() calls. Inlines with complex loops.
    > Nested inlines. Rarely called inlines (e.g. with request_region
    > inside).
    >
    > This patch removes "inline" from 15 static functions
    > (regardless of number of callsites - gcc nowadays auto-inlines
    > statics with one callsite).
    >
    > Size difference for 32bit x86:
    > text data bss dec hex filename
    > 21669 204 8780 30653 77bd linux-2.6-ALLYES/drivers/char/specialix.o
    > 18470 204 8780 27454 6b3e linux-2.6.inline-ALLYES/drivers/char/specialix.o
    >
    >
    > Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

    Ack!

    Signed-off-by: Rogier Wolff <R.E.Wolff@BitWizard.nl>

    Roger.

    --
    ** R.E.Wolff@BitWizard.nl ** http://www.BitWizard.nl/ ** +31-15-2600998 **
    ** Delftechpark 26 2628 XH Delft, The Netherlands. KVK: 27239233 **
    *-- BitWizard writes Linux device drivers for any device you may have! --*
    Q: It doesn't work. A: Look buddy, doesn't work is an ambiguous statement.
    Does it sit on the couch all day? Is it unemployed? Please be specific!
    Define 'it' and what it isn't doing. --------- Adapted from lxrbot FAQ


    \
     
     \ /
      Last update: 2008-04-08 13:53    [W:0.020 / U:17.860 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site