Messages in this thread Patch in this message | | | From | "Denis V. Lunev" <> | Subject | [PATCH 7/29] jbd2: use non-racy method for proc entries creation | Date | Tue, 8 Apr 2008 15:19:14 +0400 |
| |
Use proc_create()/proc_create_data() to make sure that ->proc_fops and ->data be setup before gluing PDE to main tree.
Signed-off-by: Denis V. Lunev <den@openvz.org> CC: sct@redhat.com CC: adilger@clusterfs.com CC: linux-ext4@vger.kernel.org --- fs/jbd2/journal.c | 17 ++++------------- 1 files changed, 4 insertions(+), 13 deletions(-)
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index 6ea7801..255e0dc 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c @@ -904,19 +904,10 @@ static void jbd2_stats_proc_init(journal_t *journal) snprintf(name, sizeof(name) - 1, "%s", bdevname(journal->j_dev, name)); journal->j_proc_entry = proc_mkdir(name, proc_jbd2_stats); if (journal->j_proc_entry) { - struct proc_dir_entry *p; - p = create_proc_entry("history", S_IRUGO, - journal->j_proc_entry); - if (p) { - p->proc_fops = &jbd2_seq_history_fops; - p->data = journal; - p = create_proc_entry("info", S_IRUGO, - journal->j_proc_entry); - if (p) { - p->proc_fops = &jbd2_seq_info_fops; - p->data = journal; - } - } + proc_create_data("history", S_IRUGO, journal->j_proc_entry, + &jbd2_seq_history_fops, journal); + proc_create_data("info", S_IRUGO, journal->j_proc_entry, + &jbd2_seq_info_fops, journal); } } -- 1.5.3.rc5
| |