Messages in this thread |  | | | Subject | Re: [PATCH] ACPI: check a return value correctly in acpi_power_get_context() | | From | Zhao Yakui <> | | Date | Tue, 08 Apr 2008 16:38:26 +0800 | |
On Mon, 2008-04-07 at 16:57 +0800, Li Zefan wrote:
> We should check *resource != NULL rather than resource != NULL,
> which will be always true.
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> ---
> drivers/acpi/power.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
> index 76bf6d9..f2a76ac 100644
> --- a/drivers/acpi/power.c
> +++ b/drivers/acpi/power.c
> @@ -121,7 +121,7 @@ acpi_power_get_context(acpi_handle handle,
> }
>
> *resource = acpi_driver_data(device);
> - if (!resource)
> + if (!*resource)
> return -ENODEV;
>
> return 0;
agreed.
|  |