lkml.org 
[lkml]   [2008]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1 resend][PPC] replace logical by bitand in pci_process_ISA_OF_ranges(), arch/powerpc/kernel/isa-bridge.c
From
Date

On Tue, 2008-04-08 at 00:26 +0200, Roel Kluin wrote:
> in arch/powerpc/kernel/isa-bridge.c:
> 41:#define ISA_SPACE_MASK 0x1
> 42:#define ISA_SPACE_IO 0x1
> ...
>
> 83: if ((range->isa_addr.a_hi && ISA_SPACE_MASK) != ISA_SPACE_IO) {
> ...
> 89: if ((range->isa_addr.a_hi && ISA_SPACE_MASK) != ISA_SPACE_IO)
>
> I think these should be single &'s, I can't test it (no hardware)
> please consider the patch below.
> --
> replace logical by bit and for ISA_SPACE_MASK
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> ---
> diff --git a/arch/powerpc/kernel/isa-bridge.c b/arch/powerpc/kernel/isa-bridge.c
> index f0f49d1..406a9e6 100644
> --- a/arch/powerpc/kernel/isa-bridge.c
> +++ b/arch/powerpc/kernel/isa-bridge.c
> @@ -80,13 +80,13 @@ static void __devinit pci_process_ISA_OF_ranges(struct device_node *isa_node,
> * (size depending on dev->n_addr_cells)
> * cell 5: the size of the range
> */
> - if ((range->isa_addr.a_hi && ISA_SPACE_MASK) != ISA_SPACE_IO) {
> + if ((range->isa_addr.a_hi & ISA_SPACE_MASK) != ISA_SPACE_IO) {
> range++;
> rlen -= sizeof(struct isa_range);
> if (rlen < sizeof(struct isa_range))
> goto inval_range;
> }
> - if ((range->isa_addr.a_hi && ISA_SPACE_MASK) != ISA_SPACE_IO)
> + if ((range->isa_addr.a_hi & ISA_SPACE_MASK) != ISA_SPACE_IO)
> goto inval_range;
>
> isa_addr = range->isa_addr.a_lo;
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev



\
 
 \ /
  Last update: 2008-04-08 01:53    [W:0.288 / U:0.000 seconds]
©2003-2011 Jasper Spaans. Advertise on this site