lkml.org 
[lkml]   [2008]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] x86: modify show_shared_cpu_map in intel_cacheinfo v2
Bert Wesarg wrote:
> On Sat, Apr 5, 2008 at 3:24 AM, Mike Travis <travis@sgi.com> wrote:
>> --- linux-2.6.x86.orig/arch/x86/kernel/cpu/intel_cacheinfo.c
>> +++ linux-2.6.x86/arch/x86/kernel/cpu/intel_cacheinfo.c
>> @@ -593,14 +593,17 @@ static ssize_t show_size(struct _cpuid4_
>>
>> static ssize_t show_shared_cpu_map(struct _cpuid4_info *this_leaf, char *buf)
>> {
>> + unsigned long end = ALIGN((unsigned long)buf, PAGE_SIZE);
> May I suggest this:
>
> ptrdiff_t len = PTR_ALIGN(buf + PAGE_SIZE - 1, PAGE_SIZE) - buf;

Hmm, that sounds great. There were a number of different methods used in
the various places to provide for that extra '\n'! ;-)

>
>> + if (len == 0)
>> + len = PAGE_SIZE;
> Than this is not necessary.
>
>> +
>> + if (len >= 2) {
>> + n = cpus_scnprintf(buf, len-2, this_leaf->shared_cpu_map);
>> + buf[n++] = '\n';
>> + buf[n] = '\0';
>> }
>> return n;
>> }
> Apart from my suggestion and the use of cpus_scnprintf I think this patch is ok.
>
> Bert
>
> PS: sorry for the long delay.

Thanks!
Mike



\
 
 \ /
  Last update: 2008-04-07 20:49    [from the cache]
©2003-2011 Jasper Spaans