lkml.org 
[lkml]   [2008]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH RFC 4/5] tun: vringfd xmit support.
Date
Rusty Russell <rusty@rustcorp.com.au> wrote:
>
> +/* We are done with this skb: put it in the used pile. */
> +static void skb_finished(struct skb_shared_info *sinfo)
> +{
> + struct skb_shinfo_tun *sht = (void *)(sinfo + 1);
> +
> + /* FIXME: Race prevention */
> + vring_used_buffer_atomic(sht->tun->outring, sht->id, sht->len);
> + vring_wake(sht->tun->outring);
> +
> + /* Release device. */
> + dev_put(sht->tun->dev);
> +}

On second thought, this is not going to work. The network stack
can clone individual pages out of this skb and put it into a new
skb. Therefore whatever scheme we come up with will either need
to be page-based, or add a flag to tell the network stack that it
can't clone those pages.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

\
 
 \ /
  Last update: 2008-04-07 07:17    [from the cache]
©2003-2011 Jasper Spaans