lkml.org 
[lkml]   [2008]   [Apr]   [6]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSun, 6 Apr 2008 13:22:08 +0200
FromIngo Molnar <>
SubjectRe: [PATCH] Fix booting pentium+ with dodgy TSC
* Rusty Russell <rusty@rustcorp.com.au> wrote:

> Linus please apply.  Almost by definition this patch can't make things 
> worse.

well, while i agree with the patch it could make things worse. In this 
case it can cause code that has been compiled to rely on TSC to 
malfunction. For if sched_clock() was using cpu_has_tsc it could return 
0 all the time, breaking the scheduler without the user having a clear 
idea why it broke. It isnt, and sched_clock() will work fine, but still, 
your "this cant make things worse" statement is not completely correct. 

In any case:

 Acked-by: Ingo Molnar <mingo@elte.hu>

and i've also queued it up into the for-.25 queue of x86.git.

	Ingo


\
 
 \ /
  Last update: 2008-04-06 13:25    [from the cache]
©2003-2008