lkml.org 
[lkml]   [2008]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] splice: use mapping_gfp_mask
    On Fri, Apr 04 2008, Oliver Pinter wrote:
    > hi all!
    >
    > this patch for 2.6.22.y ?
    >
    > if i good see, the __generic_file_splice_read bring out to 2.6.22 ..
    >
    > http://repo.or.cz/w/linux-2.6.22.y-op-patches.git
    > http://repo.or.cz/w/linux-2.6.22.y-op.git

    Loop isn't affected before 2.6.23, so while it doesn't hurt to put it
    into 2.6.22, there's not much point either. 2.6.23 and 24 need the
    patch.


    >
    > On 4/4/08, Jens Axboe <jens.axboe@oracle.com> wrote:
    > > On Thu, Apr 03 2008, Hugh Dickins wrote:
    > > > The loop block driver is careful to mask __GFP_IO|__GFP_FS out of its
    > > > mapping_gfp_mask, to avoid hangs under memory pressure. But nowadays
    > > > it uses splice, usually going through __generic_file_splice_read. That
    > > > must use mapping_gfp_mask instead of GFP_KERNEL to avoid those hangs.
    > > >
    > > > Signed-off-by: Hugh Dickins <hugh@veritas.com>
    > > > ---
    > > > Ought to go into 2.6.25. For 2.6.23 and 2.6.24 stable? Well, I've
    > > > not actually seen this hang on any of these, though presumably it's
    > > > lurking there. Where I did see it, and test the fix, was 2.6.25-rc5-mm1:
    > > > whose SLUB had a disturbing predilection (since corrected) for order-4
    > > > allocations, even when allocating radix tree nodes.
    > >
    > > Thanks Hugh, definitely correct! I see it's already merged, so all is
    > > well.
    > >
    > > --
    > > Jens Axboe
    > >
    > > --
    > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > > the body of a message to majordomo@vger.kernel.org
    > > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > > Please read the FAQ at http://www.tux.org/lkml/
    > >
    >
    >
    > --
    > Thanks,
    > Oliver

    --
    Jens Axboe



    \
     
     \ /
      Last update: 2008-04-05 09:25    [W:0.021 / U:91.440 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site