lkml.org 
[lkml]   [2008]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 05/22 -v2] blackfin: Use generic show_mem()
On Fri, Apr 4, 2008 at 4:51 AM,  <hannes@saeurebad.de> wrote:
> Remove arch-specific show_mem() in favor of the generic version.
>
> This also removes the following redundant information display:
>
> - free pages, printed by show_free_areas()
> - pages in swapcache, printed by show_swap_cache_info()
>
> where show_mem() calls show_free_areas(), which calls
> show_swap_cache_info().
>
> Signed-off-by: Johannes Weiner <hannes@saeurebad.de>
> CC: Bryan Wu <cooloney@kernel.org>
> ---
>
> Index: tree-linus/arch/blackfin/Kconfig
> ===================================================================
> --- tree-linus.orig/arch/blackfin/Kconfig
> +++ tree-linus/arch/blackfin/Kconfig
> @@ -26,7 +26,6 @@ config BLACKFIN
> default y
> select HAVE_IDE
> select HAVE_OPROFILE
> - select HAVE_ARCH_SHOW_MEM
>
> config ZONE_DMA
> bool
> Index: tree-linus/arch/blackfin/mm/init.c
> ===================================================================
> --- tree-linus.orig/arch/blackfin/mm/init.c
> +++ tree-linus/arch/blackfin/mm/init.c
> @@ -53,33 +53,6 @@ static unsigned long empty_bad_page;
>
> unsigned long empty_zero_page;
>
> -void show_mem(void)
> -{
> - unsigned long i;
> - int free = 0, total = 0, reserved = 0, shared = 0;
> -
> - int cached = 0;
> - printk(KERN_INFO "Mem-info:\n");
> - show_free_areas();
> - i = max_mapnr;
> - while (i-- > 0) {
> - total++;
> - if (PageReserved(mem_map + i))
> - reserved++;
> - else if (PageSwapCache(mem_map + i))
> - cached++;
> - else if (!page_count(mem_map + i))
> - free++;
> - else
> - shared += page_count(mem_map + i) - 1;
> - }
> - printk(KERN_INFO "%d pages of RAM\n", total);
> - printk(KERN_INFO "%d free pages\n", free);
> - printk(KERN_INFO "%d reserved pages\n", reserved);
> - printk(KERN_INFO "%d pages shared\n", shared);
> - printk(KERN_INFO "%d pages swap cached\n", cached);
> -}
> -
> /*
> * paging_init() continues the virtual memory environment setup which
> * was begun by the code in arch/head.S.
>

Thanks
Acked-by: Bryan Wu <cooloney@kernel.org>

-Bryan


\
 
 \ /
  Last update: 2008-04-04 16:45    [from the cache]
©2003-2011 Jasper Spaans