Messages in this thread | | | Date | Wed, 30 Apr 2008 22:36:42 -0400 | From | Dmitry Torokhov <> | Subject | Re: [patch, -git] input: CONFIG_INPUT_APANEL build fix |
| |
Hi Roman,
On Thu, May 01, 2008 at 02:51:47AM +0200, Roman Zippel wrote: > Hi, > > On Wed, 30 Apr 2008, Dmitry Torokhov wrote: > > > You still did not answer to the main question - do you think we should > > revert the commit that actually introduced breakage in the sense that > > anything depending on LEDS_CLASS should also add NEW_LEDS dependancy? > > That will take care of the problem (as far as LEDs are concerned) for > > _all_ subsystems and drivers at once. > > Well, that would mean reverting the complete led subsystem, since the > menuconfig patch you pointed at, isn't really the problem (did you > actually try to revert that patch?). >
Yes, I did. The revert fixed the apanel driver which does not select but rather "depends on" LEDS_CLASS for me.
> Anyway, the actual issue are all the drivers that select LEDS_CLASS > without selecting NEW_LEDS. >
This is a different issue from the original reported one.
> The patch below fixes the dependency problem without adding a lot of new > selects by using LEDS_CORE, which is selected by LEDS_CLASS/LEDS_TRIGGERS > as needed. > I removed the comments as they were a little redundant and I removed the > selects of NEW_LEDS as these are not needed anymore. > > Signed-off-by: Roman Zippel <zippel@linux-m68k.org> >
The patch appears to fix both problems at once (select and depends on + if), I like it. Could we please have it applied to mainline, please?
BTW, does this mean that all 'if'-guarded symbols should be converted to this style?
-- Dmitry
| |